[webkit-reviews] review requested: [Bug 36481] Web Inspector: Edit Tag Names : [Attachment 51811] [PATCH] "Edit Tag" and "Add Child Element"

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 36481: Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Attachment 51811: [PATCH] "Edit Tag" and "Add Child Element"
https://bugs.webkit.org/attachment.cgi?id=51811&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This really just cleans up the code and adds a few ideas but has some serious
UI issues that I have to work out. Some notes in no particular order:

- Blacklisted elements for "Edit Tag". I do not allow editing the tag name of
html, head, title, or body in either the double click or context menu. I think
doing so would likely be accidental.

- Update the closing tag. Unfortunately I do this onkeyup, which is noticeably
slow. On key down does not yet have the content in a convenient form... I will
likely need to switch this to onkeydown and do a String.fromCharCode(
event.charCode ) and make it lowercase or not depending on if the shift key is
down or not. I felt that was considerably ugly. The closing tag can be in any
number of states (non-expanded, expanded, non-existent). I gracefully handle
updating it all cases.

- There are serious UI jitters between committing the change, the front end
getting the update, and the tree being repopulated. I have to work on making
this a lot smoother. I know the setTimeout is unacceptable. I may instead add a
function to a queue of actions to be performed when the updates arrive directly
to the front-end instead of the hacky wait. I also need to prevent an expanded
node collapsing the tree before the new update comes in and expands again.

Any ideas on the UI problems would be much appreciated.