[webkit-reviews] review requested: [Bug 36481] Web Inspector: Edit Tag Names : [Attachment 51810] [PATCH] Converge on `long` for Inspector* id's

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 36481: Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Attachment 51810: [PATCH] Converge on `long` for Inspector* id's
https://bugs.webkit.org/attachment.cgi?id=51810&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This has been bothering me for a long time. Sometimes they are "long", other
times they are "int". I've made everything into a long. The only "int" that
remains is the contextMenu, which I didn't track down why it was an int.

Searching for remaining ints produced nothing obvious:

> shell> cd inspector/
> shell> ack 'int .*?id ='
> shell> ack 'int .*?Id ='
> InspectorDatabaseResource.cpp
> 43:int InspectorDatabaseResource::s_nextUnusedId = 1;
> InspectorDOMStorageResource.cpp
> 50:int InspectorDOMStorageResource::s_nextUnusedId = 1;