[webkit-reviews] review denied: [Bug 36473] Missing lock in call to doneCreatingDatabase : [Attachment 51656] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 36473: Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473

Attachment 51656: Patch
https://bugs.webkit.org/attachment.cgi?id=51656&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +	   * storage/DatabaseTracker.cpp:  Added missing lock call.

Ideally your comment would be at the function level (which is where you did
this change).

> +	   (WebCore::DatabaseTracker::canEstablishDatabase):
> +

> Index: WebCore/storage/DatabaseTracker.cpp
> +    MutexLocker lockDatabase(m_databaseGuard);
>      doneCreatingDatabase(origin, name);

It seems nicer to do this:

  MutexLocker lockDatabase(m_databaseGuard);
  if (requirement <= quotaForOriginNoLock(origin))
      return true;
  
  doneCreatingDatabase(origin, name);

Opinion?