[webkit-reviews] review requested: [Bug 35607] Allow building smoothly on win32 and win64 using GCC : [Attachment 51678] patch with fixes required by QtWebkit for mingw64 -v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 14:42:34 PDT 2010


vanboxem.ruben at gmail.com has asked  for review:
Bug 35607: Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607

Attachment 51678: patch with fixes required by QtWebkit for mingw64 -v4
https://bugs.webkit.org/attachment.cgi?id=51678&action=review

------- Additional Comments from vanboxem.ruben at gmail.com
Here's my additions/patches for your patch (with the COMPILER(MINGW64) stuff).
I can remove the check on line 554 of Collector.cpp for the compiler, but I
left it in for now, as it was originally there, probably for a good reason
(Intel Compiler maybe?). There is no reason to assume another win64 compiler
provides the functions used in that code block. I hope I got everything and
didn't mess up :)

Thanks for being so open-minded :)


More information about the webkit-reviews mailing list