[webkit-reviews] review denied: [Bug 36484] [chromium] correctly handle move drag operations : [Attachment 51605] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 36484: [chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484

Attachment 51605: Patch
https://bugs.webkit.org/attachment.cgi?id=51605&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKit/chromium/src/WebViewImpl.h
b/WebKit/chromium/src/WebViewImpl.h

> +    // Consolidate some common code between starting a drag over a target
and
> +    // updating a drag over a target.  If we're starting a drag,
|isEntering|
> +    // should be true.
> +    WebDragOperation dragTargetDragEnterOrOver(const WebPoint& clientPoint,
> +						  const WebPoint& screenPoint,
> +						  bool isEntering);

"bool isEntering" should be an enum, so it is clearer at the calling site what
the function is being passed (instead of "true/false" be passed into the
function).