[webkit-reviews] review denied: [Bug 33004] NetworkStateNotifierWin.cpp doesn't work always : [Attachment 50104] The patch (removed destructor)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 11:21:50 PDT 2010


David Levin <levin at chromium.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 33004: NetworkStateNotifierWin.cpp doesn't work always
https://bugs.webkit.org/show_bug.cgi?id=33004

Attachment 50104: The patch (removed destructor)
https://bugs.webkit.org/attachment.cgi?id=50104&action=review

------- Additional Comments from David Levin <levin at chromium.org>
There are so many whitespaces (and perhaps newline?) changes in here that it is
hard to review/figure out what changed. Please revert the unnecessary parts of
the change (even if it means using a different editor than you usually do) and
keep the change focused on the fix.

Also, there are changes to remove "onLine()" and "setNetworkAccessAllowed()"
which is only there for QT and these seem totally unrelated to the fix.

So r- due to too many unrelated changes.


More information about the webkit-reviews mailing list