[webkit-reviews] review granted: [Bug 36100] check-webkit-style: Add support for a --debug option : [Attachment 51236] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 18:41:06 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 36100: check-webkit-style: Add support for a --debug option
https://bugs.webkit.org/show_bug.cgi?id=36100

Attachment 51236: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51236&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
The change looks good, but I think -v and --verbose would be the better naming
as the name of the option to be consistent with other tools in WebKit. Also, in
WebKit, --debug usually means "debug build" so I guess this use might be a bit
confusing. Please feel free to land this patch if you like my proposal and
change the name of the option.


More information about the webkit-reviews mailing list