[webkit-reviews] review requested: [Bug 36062] Chromium should not lose activation to select popups : [Attachment 51469] Fix a crasher on LayoutTests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 18:10:27 PDT 2010


Jay Campan <jcampan at google.com> has asked  for review:
Bug 36062: Chromium should not lose activation to select popups
https://bugs.webkit.org/show_bug.cgi?id=36062

Attachment 51469: Fix a crasher on LayoutTests
https://bugs.webkit.org/attachment.cgi?id=51469&action=review

------- Additional Comments from Jay Campan <jcampan at google.com>
There was a crasher that could happen when a select popup is opened and a page
navigates.
The cause is that the PopupMenuContainer still exists but the PopupMenuClient
has been deleted, and then when hidden the popup would try to access the
PopupMenuClient, causing the crasher.
We now clear the reference to the PopupMenuClient when the popup is deleted and
we don't access it.


More information about the webkit-reviews mailing list