[webkit-reviews] review granted: [Bug 36048] Detect if the Platform SDK is missing when building with Visual C++ Express Edition : [Attachment 51221] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 36048: Detect if the Platform SDK is missing when building with Visual C++
Express Edition
https://bugs.webkit.org/show_bug.cgi?id=36048

Attachment 51221: Patch
https://bugs.webkit.org/attachment.cgi?id=51221&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +my $isBuildingWithVCExpress = 0;
>  
>  # Defined in VCSUtils.
>  sub exitStatus($);
> @@ -1026,6 +1027,7 @@ sub setupCygwinEnv()
>	       print
"*************************************************************\n";
>	       die;
>	   }
> +	   $isBuildingWithVCExpress = 1;
>      }

The name of this variable makes it sound like it will only be set to 1 when a
build is actually in progress. Maybe $willUseVCExpressWhenBuilding or something
like that would be better?

> +sub dieIfWindowsPlatformSDKNotInstalled
> +{
> +    my $windowsPlatformSDKRegistryEntry =
"/proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDK
s/D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1";
> +
> +    if (-e $windowsPlatformSDKRegistryEntry) {
> +	   return;
> +    }

This can be written as:

return if -e $windowsPlatformSDKRegistryEntry;

r=me