[webkit-reviews] review denied: [Bug 36483] webkitpy: Move the commands folder into webkitpy/patch : [Attachment 51402] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 14:31:12 PDT 2010


Eric Seidel <eric at webkit.org> has denied  review:
Bug 36483: webkitpy: Move the commands folder into webkitpy/patch
https://bugs.webkit.org/show_bug.cgi?id=36483

Attachment 51402: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51402&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think that since commands and steps contain so much stuff that is not
relating to "patching" it makes no sense to put them under a "patch" directory.
 And especially since the system is designed for other tools to be able to
include these command and steps, it seems wrong to put them under the directory
of some specific tool.

I'm against this change.


More information about the webkit-reviews mailing list