[webkit-reviews] review denied: [Bug 36495] Fix compilation on Solaris: mmap and munmap take char* : [Attachment 51431] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 36495: Fix compilation on Solaris: mmap and munmap take char*
https://bugs.webkit.org/show_bug.cgi?id=36495

Attachment 51431: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51431&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Can we instead take care of this by setting up a header to overload these
functions for void* on Solaris systems? I'd prefer a fix that doesn't require
sprinkling the non-standard code around.

Something like this:

    #if OS(SOLARIS)
    static inline void* mmap(void* addr, size_t length, int protections, int
flags, int fileDescriptor, off_t offset)
    {
	return mmap(static_cast<char*>(addr), length, protections, flags,
fileDescriptor, offset);
    }
    #endif

If we put that in file called <wtf/MManExtras.h> and included that instead of
<sys/mman.h> that would fit our normal portability approach.

review- because I'd like you to consider that option