[webkit-reviews] review requested: [Bug 36500] Generated JIT stubs does not compile because of compiler directives : [Attachment 51434] Patch to handle compiler directives

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 10:27:46 PDT 2010


David Leong <david.leong at nokia.com> has asked  for review:
Bug 36500: Generated JIT stubs does not compile because of compiler directives
https://bugs.webkit.org/show_bug.cgi?id=36500

Attachment 51434: Patch to handle compiler directives
https://bugs.webkit.org/attachment.cgi?id=51434&action=review

------- Additional Comments from David Leong <david.leong at nokia.com>
The 'create_jit_stubs' script under JavaScriptCore does not take into account
of #if compiler directives. The trunk currently does not compile for RVCT with
JIT enabled because new functions like 'op_eq_strings' are flagged by
JSVALUE32_64. 

I modified the script to look for #if, #endif and transplant them into the
generated stub file.


More information about the webkit-reviews mailing list