[webkit-reviews] review denied: [Bug 36451] [Qt] User Agent Switcher on QtLauncher : [Attachment 51309] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 36451: [Qt] User Agent Switcher on QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=36451

Attachment 51309: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51309&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +void LauncherWindow::showUserAgentDialog()
> +{
> +    QFile file("WebKitTools/QtLauncher/useragentlist.txt");

Instead of requiring that QtLauncher is started from the top-level directory by

using a relative path here, I think it would be better to compile the user
agent list
into the application using a Qt resource.

> +    , m_userAgent(QString())

This initialization isn't necessary.

> +    void setUserAgent(QString ua) { m_userAgent = ua; }

The parameter should be a const QString&.

r- until the above issues are addressed. The rest looks good to me! It's great
that you're adding this, it really helps for development/testing.