[webkit-reviews] review granted: [Bug 35870] Upstream iPhone KeyEvent platform code and share with Mac platform : [Attachment 50645] [PATCH] Part 3 - Share Code (make generic for both platforms) + FIX

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 35870: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870

Attachment 50645: [PATCH] Part 3 - Share Code (make generic for both platforms)
+ FIX
https://bugs.webkit.org/attachment.cgi?id=50645&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebCore/platform/iphone/KeyEventIPhone.mm
b/WebCore/platform/iphone/KeyEventIPhone.mm
> +    return keyIdentifierForKeyCharCode(c);

I think this should be:

    return keyIdentifierForCharCode(c);

as I don't see a keyIdentifierForKeyCharCode() method in the patch.

r=me