[webkit-reviews] review requested: [Bug 36373] [Qt] Don't construct a QLineEdit every time when painting a text field : [Attachment 51289] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 08:18:34 PDT 2010


Jakub Wieczorek <jwieczorek at webkit.org> has asked  for review:
Bug 36373: [Qt] Don't construct a QLineEdit every time when painting a text
field
https://bugs.webkit.org/show_bug.cgi?id=36373

Attachment 51289: patch
https://bugs.webkit.org/attachment.cgi?id=51289&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
OK, I went for having a QLineEdit per RenderTheme to simplify dealing with its
lifetime. This could be further improved if needed.


More information about the webkit-reviews mailing list