[webkit-reviews] review granted: [Bug 34924] Add checks if setNeedsWillValidateCheck() and setNeedsValidityCheck() are called correctly : [Attachment 48721] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34924: Add checks if setNeedsWillValidateCheck() and
setNeedsValidityCheck() are called correctly
https://bugs.webkit.org/show_bug.cgi?id=34924

Attachment 48721: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=48721&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
in HTMLInputElement::setValue, it looks like

+ setNeedsValidityCheck();

can be lifted above the "inputType() == FILE" if-clause because its called on
both branches.

This looks reasonable.	I'm not an expert on validity checks, but this patch
has been sitting around for a month and seems to prove the codebase.