[webkit-reviews] review denied: [Bug 36168] Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp : [Attachment 51190] patch 0.2

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36168: Spatial Navigation: Code simplification in FocusController.cpp and
SpatialNavigation.cpp
https://bugs.webkit.org/show_bug.cgi?id=36168

Attachment 51190: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=51190&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
You are doing many changes at once, so this makes it hard to review. Please
split this up in smaller patches, like one making use of the new isNull, etc.

The helper is confusing to me, and doesn't make it easier for me to understand
the code.

Function definitions should be on one line.

Please do not add FIXME_antonio, as told by others before.