[webkit-reviews] review granted: [Bug 36376] Assertion failure in media/video-controls-with-mutation-event-handler.html : [Attachment 51220] [PATCH] Bail in Default Handler before Attached

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 36376: Assertion failure in
media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Attachment 51220: [PATCH] Bail in Default Handler before Attached
https://bugs.webkit.org/attachment.cgi?id=51220&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index cfcd247..6742c90 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,19 @@
> +2010-03-20  Joseph Pecoraro	<joepeck at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Assertion failure in
media/video-controls-with-mutation-event-handler.html
> +	   https://bugs.webkit.org/show_bug.cgi?id=36376

Please mention the test in the ChangeLog entry here:

	Test: media/video-controls-with-mutation-event-handler.html

> +	   Break early (when not attached) in the defaultEventHandler before
the
> +	   slider is completely set up.
> +
> +	   * rendering/MediaControlElements.cpp:
> +	   (WebCore::MediaControlTimelineElement::defaultEventHandler):
> +	   (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
> +	   * rendering/RenderMedia.cpp:
> +	   (WebCore::RenderMedia::createVolumeSlider):

r=me