[webkit-reviews] review denied: [Bug 36196] REGRESSION(r52795): Cannot open complex webarchive files in Safari due to WebKit regression. : [Attachment 51185] Yong's patch with a manual test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 19 14:23:02 PDT 2010
Brady Eidson <beidson at apple.com> has denied review:
Bug 36196: REGRESSION(r52795): Cannot open complex webarchive files in Safari
due to WebKit regression.
https://bugs.webkit.org/show_bug.cgi?id=36196
Attachment 51185: Yong's patch with a manual test case
https://bugs.webkit.org/attachment.cgi?id=51185&action=review
------- Additional Comments from Brady Eidson <beidson at apple.com>
I know this is your first manual test, and when I was describing them to you I
DEFINITELY should've mentioned this - my fault.
The manual tests should be an html file with a description of the test.
Something pointing to this bug, the symptom, and what you should see to
indicate success.
Turns out that with file:// urls, you can embed webarchives as the src of an
iframe. So an html file describing the bug and the webarchive in an iframe
would be much more useful here.
Also, the ChangeLog needs to be updated to include the manual test files.
More information about the webkit-reviews
mailing list