[webkit-reviews] review granted: [Bug 36196] REGRESSION(r52795): Cannot open complex webarchive files in Safari due to WebKit regression. : [Attachment 51185] Yong's patch with a manual test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 36196: REGRESSION(r52795): Cannot open complex webarchive files in Safari
due to WebKit regression.
https://bugs.webkit.org/show_bug.cgi?id=36196

Attachment 51185: Yong's patch with a manual test case
https://bugs.webkit.org/attachment.cgi?id=51185&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Property changes on: WebCore/manual-tests/WebKitSite.webarchive
> ___________________________________________________________________
> Added: svn:executable
>    + *

To avoid problems with newlines this needs to have its MIME type set to a
binary type. Also, it should not have its executable bit set.

> +    // Internal data in SharedBuffer can be segmented.  We need to get the
contiguous
> +    // buffer.

Comment should be on a single line, and have one space after the period.

r=me, but commit-queue- because we can't land the archive without the MIME type