[webkit-reviews] review denied: [Bug 35933] [Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard : [Attachment 50812] patch for bug35933

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Shen Yi
<shenyi2006 at gmail.com>'s request for review:
Bug 35933: [Qt] [Symbian] Can not backward select (highlight) text using
virtual keyboard
https://bugs.webkit.org/show_bug.cgi?id=35933

Attachment 50812: patch for bug35933
https://bugs.webkit.org/attachment.cgi?id=50812&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think the patch is fine, but please make a unit test for this. See the
inputMethods() unit tests in WebKit/qt/tests/qwebpage.

You could test this by sending a synthetic input method event with a selection
set. After sending the event you could verify that the selection is set
correctly.