[webkit-reviews] review denied: [Bug 36270] [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport : [Attachment 51024] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus.palencia at openbossa.org>'s request for review:
Bug 36270: [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as
Viewport
https://bugs.webkit.org/show_bug.cgi?id=36270

Attachment 51024: Patch
https://bugs.webkit.org/attachment.cgi?id=51024&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm sorry, I should've been more specific :(. I didn't mean to disable OpenGl
for S60 but when it's not enabled in Qt in general. S60 was just an example.

For example it's not unusual that Qt fo Embedded Linux is compiled without
OpenGL support, too.

You can verify that OpenGL support is available in the .pro file using

contains(QT_CONFIG, opengl) {
    do opengl things
}

In addition there's a QT_NO_OPENGL define set when Qt is configured without
OpenGL support.