[webkit-reviews] review denied: [Bug 36196] REGRESSION(r52795): Cannot open complex webarchive files in Safari due to WebKit regression. : [Attachment 51041] the patch that fixes the problem

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Yong Li
<yong.li.webkit at gmail.com>'s request for review:
Bug 36196: REGRESSION(r52795): Cannot open complex webarchive files in Safari
due to WebKit regression.
https://bugs.webkit.org/show_bug.cgi?id=36196

Attachment 51041: the patch that fixes the problem
https://bugs.webkit.org/attachment.cgi?id=51041&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This code change looks good.

Unfortunately, I don't think we should land it yet because there's actually no
layout tests covering this.  The webarchive tests are disabled in DRT win
because the proper support was never added.

Since this was such a complete regression in not only WebArchives but possibly
other areas of code that exercise SharedBuffer -> CFData, I think we need to
add the DRT support and enabled the tests before we land this.

I think Andy's working on this.