[webkit-reviews] review denied: [Bug 32077] textarea grows when you type : [Attachment 50892] replaced tests with script-tests

Thu Mar 18 11:34:35 PDT 2010

Shinichiro Hamaji <hamaji at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 32077: textarea grows when you type
https://bugs.webkit.org/show_bug.cgi?id=32077

Attachment 50892: replaced tests with script-tests
https://bugs.webkit.org/attachment.cgi?id=50892&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> +
> +description('Check if the height of the textarea does not change even after
text is inserted.');

Unnecessary blank line?

> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> +<html>
> +<head>
> +<link rel="stylesheet" href="../../fast/js/resources/js-test-style.css">
> +<script src="../../fast/js/resources/js-test-pre.js"></script>
> +</head>
> +<body>
> +
> +    <div>
> +	 <textarea id="target" style="height: 100%;"></textarea> 
> +    </div>
> +    <p>(placeholder for the layout. you can ignore this.)</p><span
id="log"></span>
> +
> +<p id="description"></p>
> +<div id="console"></div>
> +<script src="script-tests/textarea-percentage-dimensions.js"></script>

When we use script-tests, the HTML should be generated by TEMPLATE.html. I
didn't notice the textarea-percentage-dimensions.js is referred by multiple
HTMLs... I'm sorry, I think we shouldn't use the script-tests framework in this
change.