[webkit-reviews] review requested: [Bug 36292] The numbers are not displayed properly when entering through VKB in number mode : [Attachment 51020] Patch

[bugzilla-daemon at webkit.org]

Kristian Amlie <kristian.amlie at nokia.com> has asked  for review:
Bug 36292: The numbers are not displayed properly when entering through VKB in
number mode
https://bugs.webkit.org/show_bug.cgi?id=36292

Attachment 51020: Patch
https://bugs.webkit.org/attachment.cgi?id=51020&action=review

------- Additional Comments from Kristian Amlie <kristian.amlie at nokia.com>
> diff --git a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp
b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp
> index ceb5ee1..5786965 100644
> --- a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp
> +++ b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp
> @@ -30,6 +30,7 @@
>  #include <QtGui/qapplication.h>
>  #include <QtGui/qgraphicssceneevent.h>
>  #include <QtGui/qstyleoption.h>
> +#include <QtGui/qinputcontext.h>
>  #if defined(Q_WS_X11)
>  #include <QX11Info>
>  #endif
> @@ -63,6 +64,8 @@ public:
>  
>      void _q_doLoadFinished(bool success);
>  
> +    void _q_updateMicroFocus();
> +
>      QGraphicsWebView* q;
>      QWebPage* page;
>  };
> @@ -80,6 +83,18 @@ void QGraphicsWebViewPrivate::_q_doLoadFinished(bool
success)
>      emit q->loadFinished(success);
>  }
>  
> +void QGraphicsWebViewPrivate::_q_updateMicroFocus()
> +{
> +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) ||
defined(Q_OS_SYMBIAN))
> +    QList<QGraphicsView *> views = q->scene()->views();
> +    for (int c = 0; c < views.size(); ++c) {
> +	   QInputContext *ic = views[c]->inputContext();
> +	   if (ic)
> +	       ic->update();
> +    }
> +#endif
> +}
> +
>  void QGraphicsWebViewPrivate::scroll(int dx, int dy, const QRect&
rectToScroll)
>  {
>      q->scroll(qreal(dx), qreal(dy), QRectF(rectToScroll));
> @@ -435,6 +450,8 @@ void QGraphicsWebView::setPage(QWebPage* page)
>	       this, SIGNAL(statusBarMessage(QString)));
>      connect(d->page, SIGNAL(linkClicked(QUrl)),
>	       this, SIGNAL(linkClicked(QUrl)));
> +    connect(d->page, SIGNAL(microFocusChanged()),
> +	       this, SLOT(_q_updateMicroFocus()));
>  }
>  
>  /*!
> diff --git a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h
b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h
> index f3afb4c..f983ae4 100644
> --- a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h
> +++ b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h
> @@ -134,6 +134,7 @@ protected:
>  
>  private:
>      Q_PRIVATE_SLOT(d, void _q_doLoadFinished(bool success))
> +    Q_PRIVATE_SLOT(d, void _q_updateMicroFocus())
>  
>      QGraphicsWebViewPrivate* const d;
>      friend class QGraphicsWebViewPrivate;