[webkit-reviews] review denied: [Bug 36292] The numbers are not displayed properly when entering through VKB in number mode : [Attachment 51020] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Kristian Amlie
<kristian.amlie at nokia.com>'s request for review:
Bug 36292: The numbers are not displayed properly when entering through VKB in
number mode
https://bugs.webkit.org/show_bug.cgi?id=36292

Attachment 51020: Patch
https://bugs.webkit.org/attachment.cgi?id=51020&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think in principle this looks good, but I can see two things missing:

* A ChangeLog entry
* A comment indicating that this is a missing feature in QGraphicsItem, ideally
with a link to an entry in the Qt JIRA tracking this missing feature. Then we
can remove this code again once it's fixed in Qt.

> +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) ||
defined(Q_OS_SYMBIAN))
> +    QList<QGraphicsView *> views = q->scene()->views();

Coding style, no space before the '*'

> +    for (int c = 0; c < views.size(); ++c) {
> +	   QInputContext *ic = views[c]->inputContext();

I think you may want to use views.at(c) instead of [], to avoid detaching the
QList that the scene returns.

> +	   if (ic)
> +	       ic->update();

Shouldn't this be a call to views.at(c)->updateMicroFocus() instead?