[webkit-reviews] review granted: [Bug 35796] Accept and bailout NULL widgets in ChromiumBridge : [Attachment 50307] Patch

Tue Mar 9 08:52:55 PST 2010

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 35796: Accept and bailout NULL widgets in ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=35796

Attachment 50307: Patch
https://bugs.webkit.org/attachment.cgi?id=50307&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/LayoutTests/fast/frames/iframe-access-screen-of-deleted.html
> @@ -0,0 +1,36 @@
> +<html>
> +<head>
> +    <script>
> +    function accessAttributes(s) {
> +	   var value = 0;
> +	   value = s.height;
> +	   value = s.width;
> +	   value = s.colorDepth;
> +	   value = s.pixelDepth;
> +	   value = s.availLeft;
> +	   value = s.availTop;
> +	   value = s.availHeight;
> +	   value = s.availWidth;
> +    }
> +
> +    function runTests() {
> +	   if (window.layoutTestController)
> +	       layoutTestController.dumpAsText();
> +	       
> +	   var f = document.getElementById('theframe');
> +	   var s = f.contentWindow.screen;
> +	   accessAttributes(s);
> +
> +	   // Now remove and check that we don't crash.
> +	   f.parentNode.removeChild(f);
> +	   accessAttributes(s);
> +    }
> +    </script>
> +</head>
> +<iframe id="theframe" src="resources/red.html"></iframe>
> +<body onload="runTests()">
> +<div>
> +This tests that accessing screen attributes doesn't crash even if containing
form is removed from the parent.

nit: "form" -> "frame"