[webkit-reviews] review granted: [Bug 35920] Test for referer information being stripped when the header is removed in willSendRequest : [Attachment 50308] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted jochen at chromium.org's request for
review:
Bug 35920: Test for referer information being stripped when the header is
removed in willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=35920

Attachment 50308: patch
https://bugs.webkit.org/attachment.cgi?id=50308&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Normally we use the misspelling "referer" only in the actual header name on the
wire and use the normal English word "referrer" everywhere else.

>  #include <JavaScriptCore/JSObjectRef.h>
>  #include <JavaScriptCore/JSRetainPtr.h>
> -#include <wtf/RefCounted.h>
> +
> +#include <set>
>  #include <string>
>  #include <vector>
>  
> +#include <wtf/RefCounted.h>

Normally our includes are in a single paragraph sorted as if by the sort tool,
not separate logical paragraphs.

> +    const std::set<std::string>& clearHeaders =
gLayoutTestController->willSendRequestClearHeaders();

Normally we do "using namespace std" in our implementation files rather than
using the "std::" prefix that is required in headers. Unless there's a name
conflict of some sort.

No downside in adding a test, unless it has intermittent failures, so we should
land this. r=me