[webkit-reviews] review granted: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 48001] Repaint only the invalidated area after scrolling

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 48001: Repaint only the invalidated area after scrolling
https://bugs.webkit.org/attachment.cgi?id=48001&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch has been waiting for dhyatt's review for over a month.  In the
meantime, the bug has gone epic and requires half an hour to understand what's
going on with this code.

In the interest of moving the project forward, I'm marking this patch r+. 
Benjamin has gotten significant feedback from a number of reviewers and has
diligently addressed all the feedback he's received (with the possible
exception of a name change requested by dhyatt).

Based on our experience with this patch, I suspect this patch will break things
when landed again.  However, I don't know how else to move this issue forward. 
Having patches sitting around waiting for review for a month is bad for the
project.

I would encourage folks working in this area to improve the test coverage of
our scrolling code.  The regressions caused by earlier iterations of this patch
point to a distinct lack of test coverage.  I was tempted to block this patch
on better test coverage, but that seemed unfair to Benjamin to appears to have
been working on this patch in ernest.