[webkit-reviews] review denied: [Bug 28452] Web Inspector freezes on expanding large/complex DOM trees : [Attachment 50311] [PATCH] Optimize Position::isCandidate() and PositionIterator::isCandidate()

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 28452: Web Inspector freezes on expanding large/complex DOM trees
https://bugs.webkit.org/show_bug.cgi?id=28452

Attachment 50311: [PATCH] Optimize Position::isCandidate() and
PositionIterator::isCandidate()
https://bugs.webkit.org/attachment.cgi?id=50311&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    bool isParentUserSelect = !nodeIsUserSelectNone(node()->parent());
>      if (renderer->isBR())
> -	   return m_offset == 0 && !nodeIsUserSelectNone(node()->parent());
> +	   return m_offset == 0 && isParentUserSelect;

I think you are regressing the general case here without any wins. Same below.