[webkit-reviews] review granted: [Bug 33590] [GTK] GObject DOM bindings : [Attachment 47928] dombindings.diff

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 33590: [GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Attachment 47928: dombindings.diff
https://bugs.webkit.org/attachment.cgi?id=47928&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I struggled with what to do with this patch.  On the one hand, it's much to
large to give anything but a syntactic review, but on the other hand, the patch
has been up for review for a while and a number of people have commented.  The
GDOM bindings seem to be in demand by a number of people and we've got to start
somewhere.

I'm surprised that there's so much code in the make files.  I would have
expected those snippets to be broken out into a separate file somehow.

In expanding the GDOM bindings, please consider using the generic bindings,
when possible, to improve maintainability.  The generic bindings don't have
much in them yet (and certainly nothing that's helpful for this patch), but
we're hoping to grow them over time.

On balance, I think we should take this patch and iterate on this code rather
than leaving the patch in review forever.