[webkit-reviews] review denied: [Bug 34601] [BREWMP] Port Heap::allocateBlock and Heap::freeBlock : [Attachment 48154] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34601: [BREWMP] Port Heap::allocateBlock and Heap::freeBlock
https://bugs.webkit.org/show_bug.cgi?id=34601

Attachment 48154: Patch
https://bugs.webkit.org/attachment.cgi?id=48154&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I would have called addressAligned alignedAddress, but that's just a nit.

To answer Eric's question, the two are different in the case were fastMalloc
returns an unaligned address because

+    addressAligned &= BLOCK_MASK;

changes the address.

This patch is horribly memory inefficient.  It seems to cause JavaScript use
about twice as much memory as necessary.  I'd recommend finding another
strategy to allocate aligned addresses.