[webkit-reviews] review denied: [Bug 35727] [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20 : [Attachment 50195] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35727: [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35727

Attachment 50195: proposed patch
https://bugs.webkit.org/attachment.cgi?id=50195&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 24 #if GTK_CHECK_VERSION(2, 18, 0)
 25 #define WIDGET_HAS_WINDOW(widget) gtk_widget_get_has_window(widget)
 26 #else
 27 #define WIDGET_HAS_WINDOW(widget) !GTK_WIDGET_NO_WINDOW(widget)

I think creating a utils file just for this is not worth it. Why not add a
function to the WidgetGtk class (or file), as Eric suggested?

 691 #if GTK_CHECK_VERSION(2, 18, 0)
 692	 if (gtk_widget_is_sensitive(widget)) {
 693 #else
691694	   if (GTK_WIDGET_IS_SENSITIVE(widget)) {
 695 #endif

This is unrelated. Please put it into another patch.