[webkit-reviews] review denied: [Bug 35747] [GStreamer] Poll messages from the bus if the player is not runned inside a glib mainloop : [Attachment 50023] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35747: [GStreamer] Poll messages from the bus if the player is not runned
inside a glib mainloop
https://bugs.webkit.org/show_bug.cgi?id=35747

Attachment 50023: proposed patch
https://bugs.webkit.org/attachment.cgi?id=50023&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Hrm. I don't know. I don't like the runtime checking, also the polling time
seems to be pretty arbitrary. I'm worried we may end up in that situation in
the gtk+ port, in some cases (say, the application hasn't run gtk_main(), but
is running the mainloop itself). Why not have ports that would like to use the
GStreamer backend run the glib main loop?