[webkit-reviews] review requested: [Bug 34819] Extraneous repaint of caret rectangle when selection is not in content editable element : [Attachment 50053] Patch with test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 4 14:14:46 PST 2010
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 34819: Extraneous repaint of caret rectangle when selection is not in
content editable element
https://bugs.webkit.org/show_bug.cgi?id=34819
Attachment 50053: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=50053&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Simon's remarks.
Also, changed SelectionController::repaintCaretInViewIfNeeded so that it uses
the Frame associated with the specified RenderView so as to handle the case
where this method may be called when the selection controller corresponds to a
drag caret (i.e. m_frame is null).
More information about the webkit-reviews
mailing list