[webkit-reviews] review denied: [Bug 35712] setenv messages too noisy in running build-webkit : [Attachment 49981] By default, suppress setenv messages from build-webkit/build-dumprendertree output.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 35712: setenv messages too noisy in running build-webkit
https://bugs.webkit.org/show_bug.cgi?id=35712

Attachment 49981: By default, suppress setenv messages from
build-webkit/build-dumprendertree output.
https://bugs.webkit.org/attachment.cgi?id=49981&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Bleh.  Yet another option hacked into build-webkit.

We had this support at some point.  Maybe some of the build scripts still do. 
The set envs are useless for most people, but I do think that the bots might
still want them (or at least that's what Mark's comment implies).

We also have a --quiet flag that we pass to run-webkit-tests which hides the
build output from build-dumprendertree entirely if I remember correctly.

So I like this change in principle.  But I think we may need to change the
buildbots to call build-* with --verbose to satisify mark's concerns.  Also,
it's sad that we continue to hack options in like this.  Would be better if
(like python) we had some sort of option dictionary that we just passed around
to all these methods.

r- because this woudl change buildbot behavior.