[webkit-reviews] review granted: [Bug 35715] WebSocket test to transfer null character : [Attachment 49993] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 35715: WebSocket test to transfer null character
https://bugs.webkit.org/show_bug.cgi?id=35715

Attachment 49993: Patch
https://bugs.webkit.org/attachment.cgi?id=49993&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, thank you for making the test!

It makes me somewhat nervous that we have the following FIXME in send():

    // FIXME: check message is valid utf8.

Can one sneak 0xff in by passing invalid UTF-16 to send()? String::utf8()
relies on platform-provided encoder, and I don't even know what ICU does for
invalid input, let alone other implementations.