[webkit-reviews] review granted: [Bug 35630] Refactoring: XMLHTTPRequest.open() should have all overloaded implementations : [Attachment 49992] v4; fix test to pass on ff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 4 10:39:35 PST 2010


Alexey Proskuryakov <ap at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 35630: Refactoring: XMLHTTPRequest.open() should have all overloaded
implementations
https://bugs.webkit.org/show_bug.cgi?id=35630

Attachment 49992: v4; fix test to pass on ff
https://bugs.webkit.org/attachment.cgi?id=49992&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +PASS: if async argument is something defined, send() should behave like as
async=true

This is not what the current code implements. The argument is converted to
boolean, so e.g. null or "" become false.

Please change "if async argument is something defined, send() should behave
like as async=true" to "if async argument is a non-empty string, send() should
behave like as async=true", because that's what the subtest verifies. One can
make this change when landing, or you could submit a new patch if you want to
use commit-queue.

r=me


More information about the webkit-reviews mailing list