[webkit-reviews] review granted: [Bug 35416] new-run-webkit-tests: split Port.check_sys_deps() into two calls : [Attachment 49657] patch revised w/ ojan's feedback: removed --nocheck-build and --nostart-helper flags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 11:32:07 PST 2010


David Levin <levin at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 35416: new-run-webkit-tests: split Port.check_sys_deps() into two calls
https://bugs.webkit.org/show_bug.cgi?id=35416

Attachment 49657: patch revised w/ ojan's feedback: removed --nocheck-build and
--nostart-helper flags
https://bugs.webkit.org/attachment.cgi?id=49657&action=review

------- Additional Comments from David Levin <levin at chromium.org>
If possible avoid the comparisons to 0 (several places have "!= 0").


More information about the webkit-reviews mailing list