[webkit-reviews] review denied: [Bug 30144] MIPS JIT Supports : [Attachment 49551] MIPS JIT Patch 20100225

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 11:09:44 PST 2010


Gavin Barraclough <barraclough at apple.com> has denied Chao-ying Fu
<fu at mips.com>'s request for review:
Bug 30144: MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

Attachment 49551: MIPS JIT Patch 20100225
https://bugs.webkit.org/attachment.cgi?id=49551&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hi Chao-ying,

Many apologies, I thought I'd added a review last week, I guess I must have
failed to hit commit.
Assuming you've fixed Gabor's review issues I'm happy, these changes look good
to land. However, as raised in my previous review, I'll like to see this landed
in two tranches.

You should be able to land yarr support with just the changes in assembler,
yarr, jit/ExecutableAllocator.h, and some of the changes to wtf/Platform.h.

Please put up a patch with just these changes & I'll be happy to r+.

cheers,
G.


More information about the webkit-reviews mailing list