[webkit-reviews] review denied: [Bug 30303] <img src=""> requests main document resource unnecessarily : [Attachment 60129] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 11:52:57 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 30303: <img src=""> requests main document resource unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=30303

Attachment 60129: patch
https://bugs.webkit.org/attachment.cgi?id=60129&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Could you please investigate and list what exactly changes with this patch?

>From the tests, I can see that <script src="">,<img src="">, <link
rel="stylesheet" href=""> are affected. What about other types of links,
appcache manifest, iframes, applets, embeds, objects, audio, video, video
poster, processing instructions?

The new tests don't check how load fails. Will there be an error event
dispatched?

r-, because we clearly need onerror testing, and further review is complicated
by lack of information about expected behavior changes. One useful thing to
investigate would be checking mailing list discussions that led to this spec
change, and related Mozilla bugs, if any.


More information about the webkit-reviews mailing list