[webkit-reviews] review requested: [Bug 41420] Canvas: arc() with startAngle == endAngle shouldn't add to the path : [Attachment 60139] Proposed patch v2

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 41420: Canvas: arc() with startAngle == endAngle shouldn't add to the path
https://bugs.webkit.org/show_bug.cgi?id=41420

Attachment 60139: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=60139&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Only unskip test on Qt, test also uses arcTo() which isn't up-to-spec on Mac I
guess.
Unfortunately I can't verify that since I don't have a Mac dev env handy.

The missing logic as implemented in Qt's Path::addArcTo():

FloatPoint p0(m_path.currentPosition());
if ((p1.x() == p0.x() && p1.y() == p0.y()) || (p1.x() == p2.x() && p1.y() ==
p2.y()) || radius == 0.f) {
    m_path.lineTo(p1);
    return;
}