[webkit-reviews] review denied: [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup : [Attachment 59922] patch v1 to set right value on UserGestureIndicator to indicate whether the NPN_Evaluate allows popup window or not.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 12:41:28 PDT 2010
Adam Barth <abarth at webkit.org> has denied Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 41292: [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in
browser, if the call is initiated by user, allow the popup
https://bugs.webkit.org/show_bug.cgi?id=41292
Attachment 59922: patch v1 to set right value on UserGestureIndicator to
indicate whether the NPN_Evaluate allows popup window or not.
https://bugs.webkit.org/attachment.cgi?id=59922&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch looks "obviously" correct. We just need a test. You should be able
to write one using the WebKit test plugin. (Also, please fix style-bots nit...
We use case-sensitive alphabetical includes for whatever reason.)
More information about the webkit-reviews
mailing list