[webkit-reviews] review denied: [Bug 41014] [GTK] Add support for the progress tag : [Attachment 59424] Add support for rendering the progress element

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 41014: [GTK] Add support for the progress tag
https://bugs.webkit.org/show_bug.cgi?id=41014

Attachment 59424: Add support for rendering the progress element
https://bugs.webkit.org/attachment.cgi?id=59424&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>--- a/WebCore/platform/gtk/RenderThemeGtk.cpp
>+++ b/WebCore/platform/gtk/RenderThemeGtk.cpp
>@@ -34,6 +34,9 @@
> #include "MediaControlElements.h"
> #include "NotImplemented.h"
> #include "RenderBox.h"
>+#if ENABLE(PROGRESS_TAG)
>+#include "RenderProgress.h"
>+#endif

Style guide says this has to go at the end of the includes in its own block.


>+bool RenderThemeGtk::paintProgressBar(RenderObject* renderObject, const
RenderObject::PaintInfo& paintInfo, const IntRect& rect)
>+{
>+    if (!renderObject->isProgress())
>+	  return true;
>+
>+    GtkWidget* progressBarWidget = moz_gtk_get_progress_widget();
>+    if (!progressBarWidget)
>+	  return true;
>+
>+    if (paintMozillaGtkWidget(this, MOZ_GTK_PROGRESSBAR, renderObject,
paintInfo, rect))
>+	  return true;
>+
>+    IntRect chunkRect(rect);
>+    RenderProgress* renderProgress = toRenderProgress(renderObject);
>+
>+    chunkRect.setHeight(chunkRect.height() - (2 *
progressBarWidget->style->ythickness));
>+    chunkRect.setY(chunkRect.y() + progressBarWidget->style->ythickness);
>+    chunkRect.setWidth(chunkRect.width() - (2 *
progressBarWidget->style->xthickness));

Don't access style like that, it won't compile with GSEAL enabled.

r- for the GSEAL stuff.