[webkit-reviews] review denied: [Bug 40222] Use the new SoupURILoader API : [Attachment 59635] WebKitGtk+ working for http/ftp/file/data protocols

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 40222: Use the new SoupURILoader API
https://bugs.webkit.org/show_bug.cgi?id=40222

Attachment 59635: WebKitGtk+ working for http/ftp/file/data protocols
https://bugs.webkit.org/attachment.cgi?id=59635&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/platform/network/soup/ResourceHandleSoup.cpp:547
 +	    client->didFinishLoading(handle.get());
You are missing checks here for the existance of the client and for cancelling.
The didReceiveData above may have cancelled it, we'll get crashes.


WebCore/platform/network/soup/ResourceHandleSoup.cpp:490
 +	    gulong gotChunkHandler = GPOINTER_TO_UINT(userData);
Eeww. I don't think this is right. This will do a cast to guint. I would prefer
removing this hack, and using a variable inside the ResourceHandleInternal hack
instead.

WebCore/platform/network/soup/ResourceHandleSoup.cpp:566
 +	// returns a stream whose outcome is a HTML with a list of files
"whose content is HTML", I think, sounds better; I don't see any special
handling for directories, though, should there be? It appears the special
handling is for any file: URIs

r- for the reasons above, I'll try to get this installed and start running with
it to get it tested =)