[webkit-reviews] review requested: [Bug 41207] absoluteRects() seems superflous : [Attachment 59761] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 05:42:44 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 41207: absoluteRects() seems superflous
https://bugs.webkit.org/show_bug.cgi?id=41207

Attachment 59761: Initial patch
https://bugs.webkit.org/attachment.cgi?id=59761&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Okay, removing absoluteRects() seems to work fine. I didn't see any regression,
compared two runs with "run-webkit-tests --tolerance 0 -p".
(Note: I updated inbetween, and got a difference in
fast/events/platform-wheelevent-in-scrolling-div.html, I can retry with a fresh
build, if the absoluteRects() change is guilty for that.)

Does anyone know how to make a test for the absoluteBoundingBoxRect() change,
that would fail before and is fixed now?


More information about the webkit-reviews mailing list