[webkit-reviews] review requested: [Bug 34508] getUniform will not work for fetching uniform array elements : [Attachment 59714] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 24 17:55:05 PDT 2010


Zhenyao Mo <zmo at google.com> has asked  for review:
Bug 34508: getUniform will not work for fetching uniform array elements
https://bugs.webkit.org/show_bug.cgi?id=34508

Attachment 59714: patch
https://bugs.webkit.org/attachment.cgi?id=59714&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
The gl-uniform-array.html test is copied from WebGL conformance tests.

Have to fix some minor bugs to make the test green:
1) For a few functions, generate INVALID_OPERATION (instead of INVALID_VALUE)
if resource is from another context.
2) useProgram(null) should work in Safari.

Tested both Chromium and Safari in Mac.


More information about the webkit-reviews mailing list