[webkit-reviews] review granted: [Bug 40607] Implement the sync DB API in workers : [Attachment 59713] patch #1: implement DatabaseSync::openDatabaseSync()

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 59713: patch #1: implement DatabaseSync::openDatabaseSync()
https://bugs.webkit.org/attachment.cgi?id=59713&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This a pretty big patch to make sure all the code is getting move around
properly, but the patch appears correct.

WebCore/storage/AbstractDatabase.cpp:137
 +	if (origin.endsWith("/"))
I still don't understand how origin can ever end with a /

WebCore/storage/AbstractDatabase.cpp:390
 +	DEFINE_STATIC_LOCAL(String, setVersionQuery, ("INSERT INTO " +
databaseInfoTableName() + " (key, value) VALUES ('" + databaseVersionKey() +
"', ?);"));
Does this mean that this table name is visible to web content?	That would be
unfortunate.