[webkit-reviews] review granted: [Bug 39472] [GStreamer] multiple video sink support : [Attachment 57337] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 39472: [GStreamer] multiple video sink support
https://bugs.webkit.org/show_bug.cgi?id=39472

Attachment 57337: proposed patch
https://bugs.webkit.org/attachment.cgi?id=57337&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
It looks very good to me. The only improvement I suggest is not creating member
variables for the queue and the tee. They are completely useless - you are not
even using them when enabling fullscreen, so just make them variables scoped to
the createGSTPlayBin function, please, unless you have a good reason to keep
them. I would prefer having more descriptive names for the queue and tee
elements, too "t" does the job, but we can do better, I guess? =)