[webkit-reviews] review granted: [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag : [Attachment 59221] viewport-patch-for-eflwebkit-10

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 40278: [EFL] EFLWebKit doesn't support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=40278

Attachment 59221: viewport-patch-for-eflwebkit-10
https://bugs.webkit.org/attachment.cgi?id=59221&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/efl/EWebLauncher/main.c:52
 +  #define ZOOM_MAX	       1.0
Is it really good with default that does not allow zooming in the example app?
WebKit/efl/EWebLauncher/main.c:379
 +   * "viewport,changed" signal will be always emitted regardless of the
viewport existence. 
viewport existence? Existence of the viewport meta tag?

WebKit/efl/ewk/ewk_view.cpp:115
 +	    } zoom_range;
zoom_range contains min_scale etc? Shouldnt it be called scale_range instead?

WebKit/efl/ewk/ewk_view.cpp:591
 +	priv->settings.zoom_range.max_scale = ZOOM_MAX;
Same here... confusing that you mix scale and zoom.